Raymond Toy writes:
> Vadim V. Zhytnikov wrote:
>> Robert Dodier writes:
>>
>>>> This seems to be a bashism. When I run find under Sun sh, I get that
>>>> list of files. When using bash, I get nothing.
>>>>
>>>> Can't we embed an actual tab character there?
>>>>
>> Yes. Even better to avoid non-ASCII chars (like x0D)
>> in Makefile one can store them in separate pattern file
>> and use grep with -f switch. This should be truly
>> portable.
>>
>>
>>>> Or maybe just make it a warning instead of an error?
>>>>
>>> Makes sense to me to make it a warning instead of an error.
>>>
>> IMHO Warning in Makefile is virtually useless.
>> Who is ever cares about warnings inside several hundred
>> kilobytes log file? Only the person who watches
>> this very particular warning. But then this person
>> can check for unexpanded Tab and DOS-EOL manually
>> without running make. My intention was not to let
>> bad data go into final build or distribution tarball.
>>
>> OK, maybe it was not a good idea.
>>
>>
> Now that you've made it portable, I think it should be in the Makefile.
> I do read the warnings (at least once in while). Since I never make
> distribution tarballs, I would never see errors, so doing that only when
> distributions are made seems like not such a good idea.
Portability turned out to be not so simple matter even for such
a trivial script. Although I found some recommendations they
aren't 100% exact. Would you please make two simple tests
in native Solaris shell
(1) Is printf command available here?
printf "a\tb"
(2) Does echo command understand -e option?
echo -e "a\tb"
Both commands should produce
a b
> Since this is pretty crucial for building everything, perhaps it would
> be a good idea for configure to test that perl 5.8 and makeinfo 4.8 are
> available? Then we don't have to deal with error reports like mine with
> ancient versions of perl and makeinfo. :-)
Yes, this is certainly right thing to do!
I'll try implement it in configure.
> Then I'd be happy with errors in the makefile instead of warnings.
OK!
--
Vadim V. Zhytnikov
<vvzhy at mail.ru>
<vvzhy at netorn.ru>