[Maxima-commits] CVS: maxima/src sin.lisp,1.25,1.26



Raymond wrote:

> > Index: sin.lisp
> > ===================================================================
> > RCS file: /cvsroot/maxima/maxima/src/sin.lisp,v
> > retrieving revision 1.25
> > retrieving revision 1.26
> > diff -u -d -r1.25 -r1.26
> > --- sin.lisp	19 Mar 2007 23:02:16 -0000	1.25
> > +++ sin.lisp	4 May 2007 14:04:56 -0000	1.26
> > @@ -23,8 +23,6 @@
> >  		      *powerl* *c* *d* exp varlist genvar repswitch $liflag
> >  		      noparts top maxparts numparts blank $opsubst))
> >  
> > -(defmvar $integration_constant_counter 0)
> > -
> >  (defmacro op (frob)
> >    `(get ,frob 'operators))
> >  
> > @@ -1413,8 +1411,7 @@
> >  	  ((mequalp exp)
> >  	   (list (car exp) (sinint (cadr exp) var)
> >  		 (add2 (sinint (caddr exp) var)
> > -		       (concat '$integrationconstant
> > -			       (incf $integration_constant_counter)))))
> > +		       (gentemp "$INTEGRATIONCONSTANT"))))
> >  	  ((and (atom var)
> >  		(isinop exp var))
> >  	   (list '(%integrate) exp var))
> >   
> I think this is wrong.  integration_constant_counter is a documented
> variable.  This used to do something with it.  Now it doesn't and you
> get some random integer appended to integrationconstant.

Yes, you are right. integration_constant_counter is a documented
variable, but you were not supposed to do something with it. Its
only use was to generate a fresh, unique symbol each time - just
what the gentemp does.
But alas I forgot to check the documentation. That is a fault.

'Andreas