Drat, I'm an idiot and just sent this to Robert Dodier before. So here
it is for the whole list, because I think the questions at the end are
relevant.
On a different topic, has anyone had a chance to look at my post re bug
580721? I'm very happy to alter what I did etc. but I think it's a
worthwhile change and would love to see it committed.
Rupert
On Sat, 2007-12-29 at 09:47 -0700, Robert Dodier wrote:
> On 12/28/07, Rupert Swarbrick <rswarbrick at googlemail.com> wrote:
>
> > This just requires a trivial call to delete-duplicates at the
> > appropriate place. To find the appropriate place was less than trivial,
> > so I reformatted $solve and added comments (apart from the addition of
> > the delete-duplicates call, there's no code _changes_ just
> > reformatting).
>
> Rupert, thanks a lot for looking into this. At this point I'd like to
> recommend that you separate the diff into two diffs: one which only
> changes comments and format, and one which has the functional changes.
> That way it is much easier to see what is going on when examining
> the cvs history. Although there have been many cvs commits which
> mix functional and non-functional changes, it's not too late to start
> separating them.
>
Hokey dokey! Sorry I didn't at first - I had to reformat the function to
understand it so that came first! :P
So there are three states:
HEAD ---------->-\---------------\
(v1.17) | |
|<-1.diff v
| (teeny) |
| |
functionality --<-/ | <- 3.diff
changed -->-\ |
| |
|<-2.diff v
| |
formatting ----<-/---------------/
too
Hope this stellar ascii art makes sense! The diffs are attached.
A question for Andrej if he's reading this:
1. Why are you dropping the nzlist stuff? I didn't really understand it,
so I presume it's pointless, but can you explain what it did/was
supposed to do?
2. (More important) Do you want to use *eql or eql on line 130? I'm not
sure though so this is a genuine question!
A question for everyone (!)
I don't understand the idiom such as at the top of solve where the prog
defines local variables $keepfloat and $ratfac. These variables aren't
used again in this function. Does this stop changes in a called function
propagating globally or something?
Rupert
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 1.diff
Type: text/x-patch
Size: 681 bytes
Desc: not available
Url : http://www.math.utexas.edu/pipermail/maxima/attachments/20080104/82abeb6c/attachment.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 2.diff
Type: text/x-patch
Size: 5699 bytes
Desc: not available
Url : http://www.math.utexas.edu/pipermail/maxima/attachments/20080104/82abeb6c/attachment-0001.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 3.diff
Type: text/x-patch
Size: 5679 bytes
Desc: not available
Url : http://www.math.utexas.edu/pipermail/maxima/attachments/20080104/82abeb6c/attachment-0002.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 307 bytes
Desc: This is a digitally signed message part
Url : http://www.math.utexas.edu/pipermail/maxima/attachments/20080104/82abeb6c/attachment.pgp