Subject: TestSuite and other Failures in today's CVS head
From: Yasuaki Honda
Date: Sun, 22 Feb 2009 12:14:50 +0900
Hi Robert, David,
Actually, unwind-protect() does nothing for this, since errors in
protected form
are not caught, only the clean-up forms are guaranteed to be executed.
If this is really the way to go, similar and effective workaround
would be to
use ignore-errors() macro.
I have committed this change to the repository.
BTW, when I saw your commit log for the unwind-protect, you wrote:
"The problem may be imaxima specific." I initially thought so, but
looking
into stream.c (or stream.d) of the clisp 2.47 source code, I found that
there are a lot of cases where setf to custom:*terminal-encoding* may
throw a run time error. So, the code must be prepared for such cases
anyway.
Yasuaki Honda
On 2009/02/22, at 11:11, David Ronis wrote:
> Hi Robert, Yasuaki,
>
> I upgraded CVS with Robert's patch and reinstalled from scratch. The
> problem remains (also the issue with colnew is still there,
> requiring me
> to manually flame it from share's Makefile). I followed Yasuaki's
> original suggestion and simply commented out the
>
> (adjust-character-encoding) at line 673; everything works properly as
> before.
>
> David
>
> P.S., which version of imaxima is currently in the maxima CVS site?
>
> On Sat, 2009-02-21 at 12:08 -0700, Robert Dodier wrote:
>> On 2/20/09, Yasuaki Honda <yhonda at mac.com> wrote:
>>
>>> If I remove the line 673 of init-cl.lisp:
>>> (adjust-character-encoding)
>>> from the definition of cl-user::run() function, imaxima works fine.
>>
>> Thanks for tracking down the error. I've committed the following
>> (wrapping UNWIND-PROTECT around the character encoding stuff).
>> Let me know if it helps.
>>
>> best
>>
>> Robert Dodier
>>
>> PS.
>> --- src/init-cl.lisp 1 Feb 2009 18:22:52 -0000 1.134
>> +++ src/init-cl.lisp 21 Feb 2009 19:01:24 -0000
>> @@ -674,8 +674,12 @@
>> (macsyma-top-level input-stream batch-flag))))))
>>
>> (defun adjust-character-encoding ()
>> - #+clisp (progn (setf custom:*default-file-encoding*
>> (ext:make-encoding :input-er
>> ror-action #\?))
>> - (setf custom:*terminal-encoding*
>> custom:*default-file-encoding*))
>> )
>> + (unwind-protect
>> + #+clisp (progn (setf custom:*default-file-encoding*
>> + (ext:make-encoding :input-error-action #
>> \?))
>> + (setf custom:*terminal-encoding*
>> + custom:*default-file-encoding*))
>> + #-clisp nil))
>>
>> (import 'cl-user::run)
>> _______________________________________________
>> Maxima mailing list
>> Maxima at math.utexas.edu
>> http://www.math.utexas.edu/mailman/listinfo/maxima
>>
> _______________________________________________
> Maxima mailing list
> Maxima at math.utexas.edu
> http://www.math.utexas.edu/mailman/listinfo/maxima