Subject: Maxima-function logxor does not work under Sbcl
From: Rupert Swarbrick
Date: Mon, 14 Nov 2011 14:27:09 +0000
Oliver Kullmann <O.Kullmann at swansea.ac.uk> writes:
> On Sun, Nov 13, 2011 at 10:40:29AM +1100, Douglas Crosher wrote:
>> Hello Oliver,
>>
>> Numerical constants were being used that vary between CL
>> implementations. Please try the following:
>>
>> logical&& logand(x,y):=?boole(?boole\-and,x,y)$
>> logor(x,y):=?boole(?boole\-ior,x,y)$
>> logxor(x,y):=?boole(?boole\-xor,x,y)$
>>
>> Regards
>> Douglas Crosher
>
> Hello Douglas,
>
> thanks! I've used the above definitions to define our own versions
> of these functions.
>
> Best
>
> Oliver
That's fine, but if you use Maxima from the current tree for testing,
you'll see that the most recent commit is:
commit 3d37105604192bd83eca92229bb75faeb014235e
Author: Douglas Crosher <dtc at users.sourceforge.net>
Commit: Douglas Crosher <dtc at users.sourceforge.net>
o logand, logor, logxor: fix the lisp constant references.
diff --git a/share/simplification/functs.mac b/share/simplification/functs.mac
index 6090050..c9156b8 100644
--- a/share/simplification/functs.mac
+++ b/share/simplification/functs.mac
@@ -30,9 +30,9 @@ rational&& rational(z):=block([n,d,cd,ratfac],
d:rat(n/ratdisrep(d*cd)),
if ratp(z) then d else ratdisrep(d))$
-logical&& logand(x,y):=?boole(boole-and,x,y)$
- logor(x,y):=?boole(boole-ior,x,y)$
- logxor(x,y):=?boole(boole-xor,x,y)$
+logical&& logand(x,y):=?boole(?boole\-and,x,y)$
+ logor(x,y):=?boole(?boole\-ior,x,y)$
+ logxor(x,y):=?boole(?boole\-xor,x,y)$
nonzeroandfreeof&& nonzeroandfreeof(x,e):=is(e#0 and freeof(x,e))$
Douglas committed this patch about six minutes before he replied to
you. Are you sure that it's worth your while hacking around bugs that
are promptly fixed, rather than relying on the new code?
Rupert
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 315 bytes
Desc: not available
URL: <http://www.math.utexas.edu/pipermail/maxima/attachments/20111114/403aec9c/attachment.pgp>;