On Wed, Jun 06, 2012 at 11:10:29PM +1000, David Billinghurst wrote:
> On 6/06/2012 11:03 PM, ?t?p?n N?mec wrote:
> >Any reason you didn't just apply the patch with `git am' or something?
> >The obvious advantages:
> >
> > - more convenient
> > - no errors would have crept in due to you manually redoing the
> > changes, as they did in this case
> > - commit metadata preserved
> >
> >Note that the "of" in the second hunk should be "or". On the plus side,
> >you also mangled my name, so I'm not so ashamed of having a typoed patch
> >applied.
> >
> >I haven't found any information on submitting patches to the Maxima
> >project, so I did what I usually do with other projects using Git. Is
> >there any such information somewhere? Did I somehow fail to adhere to
> >the usual procedure?
> >
> Apologies for mangling your name. You can blame an Australian
> English keyboard, terminal and operator. I tried to type the
> accents but gave up. I didn't mean to cause offence.
Well, you didn't, really (after all, this is not the first time similar
thing happens to me), and it actually turned out for the better in this
case. Nonetheless, I'm always astonished why anyone who does not
consider f to be a good way to represent f with a dot should consider S
a good way to represent S with a caron.
> I will patch your patch. Thanks for pointing out "git am" - I am
> new to git. I will try it next time.
If you're using Git from the command line, you might also be interested
in the --word-diff option to `git diff' and friends (also `log' etc.),
which would have made that of/or even more noticeable.
I take the lack of answer to the procedural questions as "no, there
isn't any specific information, it's OK to send patches to the mailing
list".
Thanks,
?t?p?n