[PATCH] Re: recent changes to orthopoly and kron_delta, was: Two Patches for Maxima (on SF)

On 08/22/2012 01:50 PM, Robert Dodier wrote:
> I've made some changes recently (committed & pushed) to the orthopoly
> package and kron_delta. Details are shown in the attached log. In
> summary:
> 
>  * fixed bugs in definition of kron_delta Lisp function
>  * make comments in orthopoly agree with code
>  * return simplifiable kron_delta expressions from orthopoly
>  * handle assoc_legendre_p in orthopoly_weight 
>  * express legendre_{p,q} recurrences in terms of n + 1, n, and n - 1
> 
> About the last one, I suppose it is to some degree a matter of taste.
> However, now the legendre_p & legendre_q recurrences are analogous to
> other recurrences known to orthopoly_recur, and agree with A&S 22.7.
> 
> batch(test_orthopoly) reports no errors, nor does
> batch(rtest_pochhammer, test).
> 
> Thanks to Kris Katterjohn for suggesting most of these changes.
> 

Cool.  I'm glad my patches were helpful.

While working on another, larger patch (while not terribly complicated, I had
to put it on hold due to time) I stumbled upon some *very* minor things in
orthopoly.  I've attached a patch (which is simpler than the description...)
for the following:

* Fix reference in comment (typo: A&S table 22.2, not 2.2)

* Fix(?) merror directive in message in orthopoly_weight: change ~:m to ~:M.
I'm not actually sure of the difference (if there is one), but the majority of
calls (including the others in orthopoly) seem to use the capitalized one
instead.  The lowercase version seems to work fine, though.  (If there is a
difference, I'd like to know what it is.)

* Trivial capitalization in the same message as above.  This capitalizes the
first letter and also "Maxima".  This makes it consistent with other error
messages there (including one visible at the top of the patch).

Nothing too deep here, just some random things I found.  I thought I'd send
them in and get it out of the way before I start getting busier and probably
forget.

> best,
>
> Robert Dodier
>

Cheers,
Kris Katterjohn
-------------- next part --------------
A non-text attachment was scrubbed...
Name: orthopoly-minor.patch
Type: text/x-patch
Size: 795 bytes
Desc: not available
URL: <http://www.math.utexas.edu/pipermail/maxima/attachments/20120823/d5740aa8/attachment.bin>;