use of eval in sin.lisp



Yes, please do.  The 'every' version is cleaner, clearer, and faster....

           -s

On Sun, Feb 17, 2013 at 12:23 PM, Andreas Eder <andreas_eder at gmx.net> wrote:

> Hi,
>
> in the file "sin.lisp" in function "elem" i found a use of "eval"
> that seems dubious to me, because as far as I can see it can be
> easily replaced with a call to the function "every":
>
> 80c80
> <       (t (eval (cons 'and (mapcar #'elem (cdr a)))))))
> ---
> >       (t (every #'elem (cdr a)))))
>
> Am I missing something?
> The test suite runs fine with the changed definition.
> If nobody objects or shows me my false ways, shall I commit that
> change to the master branch?
>
> Andreas
> --
> ceterum censeo redmondinem esse delendam.
> _______________________________________________
> Maxima mailing list
> Maxima at math.utexas.edu
> http://www.math.utexas.edu/mailman/listinfo/maxima
>