Raymond Toy <toy.raymond at gmail.com> writes:
> Yes, I'm pretty happy with these changes. Except for the fgrep. We
> should probably change common-lang-recode.mk to be created via
> configure so we can do the right thing with fgrep (and iconv and
> recode).
Ah, you mean use $(FGREP) like $(MKDIR_P) etc.? Cool, but we don't need
to make common-lang-recode.mk via configure: it gets included into
Makefiles by Automake, so all of these variables get set and we can just
use them. @FOO@ doesn't work, I don't think, but $(FOO) will.
> Oh, and one other comment. You create
> lisp-utils/parse-info-$lisp.$fasl. Would it make sense to follow what
> the rest of maxima does and put the compiled result in
> lisp-utils/binary-$lisp/parse-info.$fasl? This might be easier if
> parse-info.lisp were in src instead of lisp-utils, but lisp-utils
> seems to be the right place for it.
Good point. I'll do that.
> Rupert> Thank you for going through the code so thoroughly. All of my Unix
> Rupert> experience has been on Linux (and most of my developing, for that
> Rupert> matter), so I find this sort of portability hard to get right.
>
> I haven't actually reviewed all of your code. I just did enough to
> make it work on solaris 10. :-)
:-)
> Overall, I find the the parse-info code works fine except that things
> like ? mnewton return two entries. The old system returned just one.
> This needs to be fixed. And we also need to test this on Windows to
> make sure it works there.
Yes, I know that still needs doing. It's because I've not yet put the
logic (back) in to ignore top-level chapter headings. That should be
easy to fix, since I put in the infrastructure it needs when I was doing
stuff at run-time.
Rupert
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 315 bytes
Desc: not available
URL: <http://www.math.utexas.edu/pipermail/maxima/attachments/20130509/4b58b1df/attachment.pgp>;