Raymond Toy <toy.raymond at gmail.com> writes:
>>>>>> "Rupert" == Rupert Swarbrick <rswarbrick at gmail.com> writes:
>
> Rupert> I *think* that the parse-info branch is now ready for merging.
> Rupert> Things that have changed recently:
>
> Before merging, I think you should give people a couple of weeks for
> testing with the latest code. (Might seem like a long time, but we're
> all volunteers.)
Absolutely! Sorry, what I meant is something like: "I don't know of any
missing features or obvious bugs, so please can people take a look at
the code. It won't be a waste of their time because I have no intention
of rewriting great swathes of the branch"
> Rupert> This *hasn't* been tested on Windows. So is there any
> Rupert> chance someone could give it a go? (I don't have a Windows
> Rupert> machine to test on, I'm afraid) Provided things work
> Rupert> sensibly there, I think the master branch will now be
> Rupert> improved by merging in parse-info.
>
> Without testing on Windows, I would have to vote no on merging,
> unfortunately.
I agree. Which is why I started the sentence with "Provided things work
sensibly there..." :-)
> I wish there were a way to say at runtime to use the new parse-info
> way or the old way, in case we find issues. But that might be more
> effort than it's worth. And IIRC the changes are fairly large so if
> we do find issues, reverting the parse-info merge may be somewhat
> difficult.
They are. I confess that some of the changes would have made sense for
master without the parse-info changes, but it would have been messy to
make two versions because I moved some of the localisation stuff
around. So I was lazy...
I don't think it's really worth a runtime flag: after all, most of the
complexity only gets run at build time. The code that loads up the
relevant offset files and uses them is pretty simple.
Rupert
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 315 bytes
Desc: not available
URL: <http://www.math.utexas.edu/pipermail/maxima/attachments/20130527/e9b4c838/attachment.pgp>;