[Maxima-commits] [git] Maxima CAS branch, master, updated. branch-5_31-base-183-gf44d669

>Leo: Great, thanks for sending a patch. It would have been helpful if
>you'd answered some of my questions, as well / instead. I still don't
>really know what you think about some of the things I raised.

Hmmm, I didn't see the email in my inbox, and I have only just read it
on the webpage at

http://www.math.utexas.edu/pipermail/maxima/2013/034687.html

Let me summarize my thoughts: I have said that the sort of hook you
had written with prompt-notes was over-engineered and not suitable for
src. I also said that I am not sure any hook should be in
format-prompt.  But, if there is to be one, make it as unobtrusive as
possible. I think the patch (for src/macsys.lisp) I sent does that.

>I'm going to put comments inline, but the conclusion: This patch removes
>my code (fine), adds a broken replacement and also adds an interface for
>Maxima code to customise *alt-display1d* and *alt-display2d*. I believe
>that this last part is unrelated to my changes under discussion.

We can disagree on whether it is broken because the mfuncall is not
wrapped in an unwind-protect. Does your home-owner's insurance cover
your lighting your drapes on fire?

The contrib code to customise alt-display can do everything you wanted
with your prompt-notes. In fact, I realized while writing the commit
log that the examples I provided only use it and do not use the
$format_prompt hook.

I believe the alt-display code provides a reasonable interface from
Maxima to create customized prompts from the Maxima repl.

Leo