On Sat, 2004-12-04 at 10:57, Andreas Eder wrote:
> Hello List,
>
> I had some spare time to burn over the last few days and so I have
> come up with another set of code cleanups.
> It passes all checks and makes the code easier to understand (in my
> opinion) and removes some warnigs from compiles.
> Please have a look at it and decide wether it would be worthwhile to
> include it.
> I hope that over time I can make it compile cleanly without any
> warnings :-).
Dear Andreas,
I started to go over your previous set of patches just before you sent
in this set. It is very good that you are taking the time to fix up the
many warnings present in the current compile.
Before I commit this sort of submitted patch to cvs, I try to go through
all the changes myself. While some of the modifications you have made
are obvious to me, many are not. If I continue reading through them
without any guidance, it will probably take me as long as it took you to
write them in the first place. Would it be possible to write up a short
set of notes on the changes you have implemented? A few pointers would
go a long way.
--Jim