Viktor Toth wrote:
> Update of /cvsroot/maxima/maxima/src
> In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv22974
>
> Modified Files:
> simp.lisp
> Log Message:
>
> Changes by Volker van Nek to improve handling of lists.
>
>
> Index: simp.lisp
> ===================================================================
> RCS file: /cvsroot/maxima/maxima/src/simp.lisp,v
> retrieving revision 1.60
> retrieving revision 1.61
> diff -u -d -r1.60 -r1.61
> --- simp.lisp 17 Nov 2008 12:55:41 -0000 1.60
> +++ simp.lisp 20 Nov 2008 22:54:59 -0000 1.61
> @@ -202,6 +202,10 @@
> (and (not (atom x)) (not (atom (car x)))
> (member (caar x) '(rat bigfloat)))))
>
> +(defmfun mlistp (x) ;; VTT
> + (and (not (atom x)) ;; VTT
> + (eq (caar x) 'mlist))) ;; VTT
> +
>
Is it really necessary to add ";; VTT" after each line that you
changed? The commit log tells use who did the change, and such things
just pollute diffs with extraneous things. cvs annotate will tell us
too (sometimes).
I'd much rather see a useful comment on what the change is actually
doing. I don't really know what the change (that I snipped), actually does.
However, I don't have problems if you add your name about a comment or
question about hairy parts of the code. :-)
Ray, who is guilty of not documenting changes as well as he should.