The contents of sloop.lisp in src is :
(in-package :cl-sloop)
(defmacro sloop (&rest body) `(loop , at body))
So 'sloop' is the same 'loop' which is in cl hyperspec. I guess sloop
used to be something different until GCL got proper 'loop'
implementation (or something like that)..
So it will work correctly if you put 'loop' instead of 'sloop'
because that's how 'sloop' is currently defined.
It wouldn't change or break anything.
The motivation for this is 1 less file in /src/, 1 less 'package'...
I wouldn't even run the testsuite. It's a code cleanup essentially,
not a change. Ok maybe I was optimistic - it's a 3 minute change, a
10 minute compile and a 10 minute test... if anyone has time or
motivation..
Regards,
Ziga
On Sep 8, 2009, at 2:18 AM, Barton Willis wrote:
>
> (1) Does the change fix any bugs?
> (2) Does the change introduce new bugs? If not, how do you know? How
> certain are you?
> (3) Does the change extend Maxima's mathematical abilities?
> (4) Does the change break code in share?
> (5) Does the change break useful Maxima code that isn't in the Maxima
> distribution? How do you know?
> (6) Does the change work with all supported versions of CL?
> (7) Does the testsuite test every changed line of code? If not,
> how do you
> know the changes are correct?
>
> It's more than three minutes of work. Last I noticed, just running the
> share
> test suite on my machine takes about 400 seconds.
>
> Barton
>
> -----maxima-bounces at math.utexas.edu wrote: -----
>
>
>> I noticed that there is a package in maxima called 'sloop' which
>> shadows CL's loop macro. Grepping in the root maxima dir gives:
>
>> I think we can remove it. It's roughly 20 changes in 6 files.. 3
>> minutes of work.
>