(1) The function GiveC(angle,radius) is missing block([w], ...). Same for GiveNextPoint, I think.
(2) Not that it really matters, all return statements can be eliminated (see documentation for 'block'); for example
cc:map('float,cc),
return(cc))$
could be
map('float,cc))$
If you like the explicit return, there is no harm in using them.
(3) Maybe variables in GiveRay(t,c) might need to be declare local? I'm not sure--look at the *.UNLISP file generated by the compiler.
Not a Maxima style guru, but may these comments are useful.
--Barton
________________________________________
From: maxima-bounces at math.utexas.edu [maxima-bounces at math.utexas.edu] on behalf of Adam [adammaj1 at o2.pl]
Sent: Wednesday, November 07, 2012 14:33
To: maxima at math.utexas.edu
Subject: Maxima style
Dear Maxima-team & users,
I have made simple image using Maxima
http://commons.wikimedia.org/wiki/File:Dynamic_internal_and_external_rays_.svg
The source code is included.
Code works , but I would like to ask :
if the code is in proper Maxima style ?
Can I do it better ?
I remember that :
it is better to use define instead of :=
Sth more ?
TIA
Adam
_______________________________________________
Maxima mailing list
Maxima at math.utexas.edu
http://www.math.utexas.edu/mailman/listinfo/maxima