>>>>> "Rupert" == Rupert Swarbrick <rswarbrick at gmail.com> writes:
Rupert> Raymond Toy <toy.raymond at gmail.com> writes:
>> I might consider having maxima look at locale (or local-subdir)
>> and set up the default external format and stream external
>> format to use it.
Rupert> Does the commit at [1] look sane to you? If it doesn't
Rupert> look like we'll ever merge the parse-info branch, we can
Rupert> always back-port it, but this seemed like it belonged in
Rupert> the new locale.lisp file, so I thought I'd put it in there
Rupert> for now.
Too bad there's no code review tool on sourceforge.
A few comments for cmucl.
o It #+cmu, not #+cmucl, in general. The :cmucl feature is fairly
new.
o Should guess-external-format default to utf8? I think we should
default to whatever the system thinks when the encoding isn't
listed.
o In set-terminal-encoding, if you actually care about versions that
don't have set-system-external-format, you need to do something like
#+cmu
(let ((set-format (find-symbol "SET-SYSTEM-EXTERNAL-FORMAT" "STREAM")))
(when (and set-format (fboundp set-format))
(funcall set-format external-fmt)))
I'll play around with this a bit and check in appropriate changes if
you don't get to them before I do.
Ray