Raymond Toy <toy.raymond at gmail.com> writes:
> Too bad there's no code review tool on sourceforge.
Well, a mailing list with developers on it isn't so bad. I guess one can
always paste offending hunks inline...
> A few comments for cmucl.
>
> o It #+cmu, not #+cmucl, in general. The :cmucl feature is fairly
> new.
Ah, thanks, I hadn't realised.
> o Should guess-external-format default to utf8? I think we should
> default to whatever the system thinks when the encoding isn't
> listed.
What do you mean by the system here? The operating system? In which
case, how can we tell? (This is a genuine question!)
The "punt to utf-8" logic was basically because I expect a higher and
higher percentage of systems to be set to UTF-8 as time goes on. Thus,
I think this has the highest probability of being right if we just
choose a constant encoding when $LANGUAGE and friends aren't set. But if
we can be cleverer, that's even better... I should say, I'm not really
up for reimplementing half of nl_langinfo for a corner case that I don't
expect us to exercise much.
> o In set-terminal-encoding, if you actually care about versions that
> don't have set-system-external-format, you need to do something like
>
> #+cmu
> (let ((set-format (find-symbol "SET-SYSTEM-EXTERNAL-FORMAT" "STREAM")))
> (when (and set-format (fboundp set-format))
> (funcall set-format external-fmt)))
Oops, good point. That'll apply for the ECL one too.
> I'll play around with this a bit and check in appropriate changes if
> you don't get to them before I do.
It might be a couple of days before I get more time to play with this,
so great!
Rupert
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 315 bytes
Desc: not available
URL: <http://www.math.utexas.edu/pipermail/maxima/attachments/20130507/7eab12ad/attachment.pgp>;