Rupert Swarbrick <rswarbrick at gmail.com> writes:
> Dan Gildea <dgildea at users.sourceforge.net> writes:
>> asksign1 should return $pos, not $pn - I think this bug dates to:
>>
>> commit 5e23e720414b8011f97ae5c31bc304eb151534eb
>> Author: Rupert Swarbrick <rswarbrick at gmail.com>
>> Date: Wed Feb 13 23:41:14 2013 +0000
>>
>> Significantly refactor ASKSIGN1
>
> Oops, you're right. The root of the problem is that I didn't realise
> that the code needs to treat things of the form a^2 differently from how
> it treats stuff that isn't squared. I sort of ended up with a mangled
> copy. Anyway, I'm just polishing up a fixed version and will commit it
> in the next hour or two. Currently trying to work out how to write a
> good unit test for it.
Fix pushed. Sorry for messing everyone around. There's also now a test
in the testsuite that checks that
assume (notequal (x, 0));
is (x^2 > 0);
yields true (which it didn't with my mistake).
Rupert
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 315 bytes
Desc: not available
URL: <http://www.math.utexas.edu/pipermail/maxima/attachments/20130522/4c2befc8/attachment.pgp>;